Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[POC] Change VLAN_TABLE priority as same as VLAN_MEMBER_TABLE. #3537

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

liuh-80
Copy link
Contributor

@liuh-80 liuh-80 commented Feb 27, 2025

Change VLAN_TABLE priority as same as VLAN_MEMBER_TABLE.

Why I did it

Fix issue sonic-net/sonic-buildimage#20941
This issue caused by 2 reason:

  1. VLAN_TABLE has higher priority than VLAN_MEMBER_TABLE
  2. select return object by recent used time, it should return by event happen time. this issue fix by another PR: [POC] Improve select and selectable to return same priority event by event happen time. sonic-swss-common#981

How I did it

Change VLAN_TABLE has same priority with VLAN_MEMBER_TABLE

Work item tracking
  • Microsoft ADO: 30468564

How to verify it

Pass all test cases.
Pass all sonic-mgmt test with this PR: sonic-net/sonic-buildimage#21875

Manually build a POC and verify with following test steps:

sudo config vlan add 4094
sudo config vlan member add 4094 Ethernet64

sudo kill -s SIGSTOP $(pgrep -f /usr/bin/orchagent)

sudo config vlan member del 4094 Ethernet64
sudo config vlan del 4094

sudo truncate -s 0 /var/log/syslog
sudo kill -s SIGCONT $(pgrep -f /usr/bin/orchagent)
sudo cat /var/log/syslog

Result:

// VLAN_MEMBER delete event happen first and pop first:
2025 Feb 27 02:06:51.606321 vlab-01 NOTICE swss#orchagent: :- removeVlanMember: Remove member Ethernet64 from VLAN Vlan4094 lid:ffe vmid:2700000000069e
2025 Feb 27 02:06:51.606687 vlab-01 NOTICE swss#orchagent: :- flushFdbEntries: flush key: SAI_OBJECT_TYPE_FDB_FLUSH:oid:0x21000000000000, fields: 3
2025 Feb 27 02:06:51.606769 vlab-01 NOTICE swss#orchagent: :- recordFlushFdbEntries: flush key: SAI_OBJECT_TYPE_FDB_FLUSH:oid:0x21000000000000, fields: 3

2025 Feb 27 02:06:51.689459 vlab-01 NOTICE swss#orchagent: :- removeVlan: Remove VLAN Vlan4094 vid:4094

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

Description for the changelog

Change VLAN_TABLE priority as same as VLAN_MEMBER_TABLE.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liuh-80 liuh-80 changed the title Change VLAN_TABLE priority as same as VLAN_MEMBER_TABLE. [POC] Change VLAN_TABLE priority as same as VLAN_MEMBER_TABLE. Feb 27, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants